Base Affine on attrs #111
Merged
Base Affine on attrs #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgillies
commented
Dec 28, 2024
sgillies
commented
Dec 30, 2024
| rev: v1.13.0 | ||
| hooks: | ||
| - id: mypy | ||
| additional_dependencies: [attrs] |
Member
Author
There was a problem hiding this comment.
Required to use the attrs mypy plugin.
sgillies
commented
Dec 30, 2024
Member
Author
|
@mwtoews what do you think? |
This was referenced Dec 30, 2024
mwtoews
approved these changes
Jan 1, 2025
Contributor
mwtoews
left a comment
There was a problem hiding this comment.
Changes look good! I had a look at std dataclasses too, but found the transition not clear-cut. I had a look at refactoring with typing.NamedTuple too (shown here), but this didn't look any better. While I'm not an attrs user, this dependency seems well maintained.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Namedtuple is a bit awkward to use and today people would expect Affine to be a modern data class. I tried to use the stdlib's dataclasses at first, but was blocked by the lack of converters.
Will rebase this once #110 is merge.