Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat : add plugin manager #434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 31, 2022
Merged

feat : add plugin manager #434

merged 8 commits into from
Jul 31, 2022

Conversation

@smarchone
Copy link
Member

@smarchone smarchone commented Jul 5, 2022 •
edited
Loading

New Features:

  • optimus serve --install-plugins
  • optimus plugin install [hidden]
  • sample plugin config within optimus server config
plugin:
  dir: "." # plugin discovery logic needs to be as is (support current client plugins)
  artifacts:
    # refer : https://github.com/hashicorp/go-getter
    - ../transformers/dist/transformers_0.1.0_macos_arm64.tar.gz
    - ../transformers/dist/transformers_0.1.0_windows_x86_64.zip
    - https://github.com/odpf/optimus/releases/download/v0.2.5/optimus_0.2.5_linux_arm64.tar.gz

@smarchone smarchone marked this pull request as draft July 5, 2022 21:22
@smarchone smarchone linked an issue Jul 5, 2022 that may be closed by this pull request
Plugin Manager : Support Basic Plugin Manager to install plugins #363
Closed
2 tasks
@smarchone smarchone changed the title add plugin manager feat : add plugin manager Jul 5, 2022
@coveralls
Copy link

coveralls commented Jul 5, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2734147557

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 77.85%
Totals Coverage Status
Change from base Build 2731060945: 0.02%
Covered Lines: 7683
Relevant Lines: 9869
💛 - Coveralls

@smarchone smarchone marked this pull request as ready for review July 6, 2022 04:29
@smarchone smarchone requested a review from sravankorumilli July 6, 2022 04:39
sravankorumilli
sravankorumilli requested changes Jul 17, 2022
View reviewed changes
deryrahman
deryrahman requested changes Jul 22, 2022
View reviewed changes
@smarchone smarchone requested a review from deryrahman July 25, 2022 17:43
@sravankorumilli sravankorumilli merged commit 2edbafe into main Jul 31, 2022
@sravankorumilli sravankorumilli deleted the plugin-manager branch July 31, 2022 15:24
sravankorumilli pushed a commit that referenced this pull request Aug 1, 2022
@smarchone @sravankorumilli
feat : add plugin manager (#434)
067771e 
* add plugin manager

* fix : change flag to --install-plugins

* fix : cosmetic changes

* fix : make current dir default for plugins

* fix : config test and remove comments

* fix : review feedback

* fix go mod

* minor fix
sravankorumilli pushed a commit that referenced this pull request Aug 2, 2022
@Mryashbhardwaj @smarchone @arinda-arif
fix: deployed jobs folder to use namespace name instead of namespace …
7cd7f98 
…id (#440)

* fix: deployed jobs folder to use namespace name instead of namespace id

* fix: delete namespaceId folder from scheduler

* fix: refactor the old job folder delete flow

* fix: WPI

* fix: add deletion flow for removing old dag directories

* feat : add plugin manager (#434)

* add plugin manager

* fix : change flag to --install-plugins

* fix : cosmetic changes

* fix : make current dir default for plugins

* fix : config test and remove comments

* fix : review feedback

* fix go mod

* minor fix

* chore: update proton commit of adding unknown_dependencies field (#475)

Co-authored-by: Saikumar Chintada <[email protected]>
Co-authored-by: Arinda Arif <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sravankorumilli sravankorumilli sravankorumilli approved these changes

@deryrahman deryrahman Awaiting requested review from deryrahman

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Plugin Manager : Support Basic Plugin Manager to install plugins

5 participants

@smarchone @coveralls @sravankorumilli @deryrahman