feat: get compiled job assets from JobRunInput api #435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Sandeep Bhardwaj <[email protected]>
Pull Request Test Coverage Report for Build 2838115849
💛 - Coveralls |
sravankorumilli
requested changes
Jul 17, 2022
Contributor
|
I think it is better to create another PR for deprecating the old admin build instance command and the corresponding api |
sravankorumilli
requested changes
Aug 8, 2022
Mryashbhardwaj
commented
Aug 9, 2022
Member
Author
Mryashbhardwaj
left a comment
There was a problem hiding this comment.
ready for review
sravankorumilli
approved these changes
Aug 11, 2022
| >>>>>>> 4e23e7628ddeb1cc952e104a34959ebaf8a19451 | ||
|
|
||
| "scheduled_at" : current_schedule_date.strftime(TIMESTAMP_FORMAT), | ||
| "scheduled_at_ts" : datetime.timestamp(current_schedule_date), |
Contributor
There was a problem hiding this comment.
this is still there
| current_dag_run_id = context.get('dag_run').run_id | ||
| schedule_time = context.get('next_execution_date') | ||
| ======= | ||
| "task_start_timestamp" : datetime.timestamp(context.get('task_instance').start_date), |
Contributor
There was a problem hiding this comment.
task_start_timestamp too is still there
|
|
||
| def execute(self, context): | ||
|
|
||
| log_start_event(context, EVENT_NAMES.get("TASK_START_EVENT")) |
Contributor
There was a problem hiding this comment.
you should merge these commits into one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
proton PR:: raystack/proton#155
Future plans : #443