refactor: simplify observer response #445
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2815400061
💛 - Coveralls |
5e8884f to
b5b5e08
Compare
c51f1f8 to
4e10226
Compare
sravankorumilli
approved these changes
Jul 28, 2022
* feat: add log sender + progress count sender * refactor: remove observer from refresh job * fix: unmarshaling deployID to be printed * refactor: sender -> writer
* refactor: use log sender instead of observer for deploy job spec * refactor: remove unecessary response processing on client side * fix: linter + remove unused job deploy event * fix: test case * fix: marshaling deployID * refactor: deploy job response writer * refactor: remove sender package * feat: update proton version * refactor: use responseWriter * test: improve test coverage
* feat: add log sender + progress count sender * feat: add log sender + progress sender for resource deploy response * refactor: use stream sender directly to send log and progress on deploy resource * refactor: remove observer progress on create resource + inject logger * refactor: sender -> writer * refactor: remove sender package * refactor: remove progressbar
39dd300 to
6eb6389
Compare
1f83756 to
988f907
Compare
sravankorumilli
approved these changes
Aug 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This following stream response that use observer for sending messages:
NB: Observer refactoring for non stream responses are not covered by this PR