-
Notifications
You must be signed in to change notification settings - Fork 154
feat: support window versioning #471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
53414eb to
6354f22
Compare
28bc816 to
f5b1d68
Compare
Pull Request Test Coverage Report for Build 3000753601
💛 - Coveralls |
03de2d7 to
6fd21d7
Compare
…ing to existing client
…oid cyclic dependency
Note: these unit tests might not make sense at some point, as the old implementation is buggy. The old version is retained as much as possible, to allow for short-term backward compatibility. Later, old version (or in this case version 1) will be deprecated
…n't implement it, avoid saving OldWindowSize & Offset as it is not needed
* chore: pull in window playground from private repository * refactor: update implementations to be more consistent and readable * docs: add a separate line between banner and input * docs: update to add documentation
12f0910 to
c9922a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to address issue (#453). In order for this PR to be merged, the following should be merged:
Also, as being impacted by this PR, the following PR need to be merged as well:
To play around with this feature, the following PR also need to be merged: