Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@irainia
Copy link
Member

@irainia irainia commented Jul 26, 2022

This PR is to address issue (#453). In order for this PR to be merged, the following should be merged:

  • proton PR: related to the contract being used as communication
  • extended branch PR: this fixes and add additional implementations to the current branch, though the approach can be changed further

Also, as being impacted by this PR, the following PR need to be merged as well:

To play around with this feature, the following PR also need to be merged:

@irainia irainia requested a review from sravankorumilli July 27, 2022 10:45
@irainia irainia marked this pull request as ready for review July 27, 2022 10:45
@irainia irainia linked an issue Jul 27, 2022 that may be closed by this pull request
2 tasks
@coveralls
Copy link

coveralls commented Sep 5, 2022

Pull Request Test Coverage Report for Build 3000753601

  • 278 of 403 (68.98%) changed or added relevant lines in 10 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.3%) to 76.275%

Changes Missing Coverage Covered Lines Changed/Added Lines %
job/replay.go 2 4 50.0%
api/handler/v1beta1/adapter.go 19 23 82.61%
compiler/job_asset_compiler.go 9 13 69.23%
service/job_run_service.go 9 13 69.23%
store/local/job_spec_adapter.go 17 23 73.91%
api/handler/v1beta1/job_run.go 9 16 56.25%
models/window.go 23 35 65.71%
compiler/job_input_render.go 0 14 0.0%
models/window_v2.go 100 128 78.13%
models/window_v1.go 90 134 67.16%
Files with Coverage Reduction New Missed Lines %
api/handler/v1beta1/job_run.go 2 72.18%
Totals Coverage Status
Change from base Build 2999150845: -0.3%
Covered Lines: 7568
Relevant Lines: 9922

💛 - Coveralls

@sravankorumilli sravankorumilli force-pushed the window-versioning branch 2 times, most recently from 03de2d7 to 6fd21d7 Compare September 5, 2022 15:31
sravankorumilli and others added 22 commits September 6, 2022 19:11
irainia and others added 15 commits September 6, 2022 19:11
Note: these unit tests might not make sense at some point, as the old implementation is buggy.
The old version is retained as much as possible, to allow for short-term backward compatibility.
Later, old version (or in this case version 1) will be deprecated
…n't implement it, avoid saving OldWindowSize & Offset as it is not needed
* chore: pull in window playground from private repository

* refactor: update implementations to be more consistent and readable

* docs: add a separate line between banner and input

* docs: update to add documentation
@sravankorumilli sravankorumilli merged commit 3cfc9df into main Sep 6, 2022
@sravankorumilli sravankorumilli deleted the window-versioning branch September 6, 2022 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

start and end times are not computed as per expectations

4 participants