Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: add AddJobSpecifications api & refactor createJobSpecification api #537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Sep 2, 2022
Merged

feat: add AddJobSpecifications api & refactor createJobSpecification api #537

merged 17 commits into from
Sep 2, 2022

Conversation

@Mryashbhardwaj
Copy link
Member

@Mryashbhardwaj Mryashbhardwaj commented Aug 24, 2022 •
edited
Loading

fixes: #531

Proton PR: raystack/proton#179

PS:

@coveralls
Copy link

coveralls commented Aug 24, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2977124082

  • 41 of 50 (82.0%) changed or added relevant lines in 5 files are covered.
  • 5 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.7%) to 76.541%
Changes Missing Coverage Covered Lines Changed/Added Lines %
api/handler/v1beta1/job_run.go 0 2 0.0%
api/handler/v1beta1/job_spec.go 28 31 90.32%
job/service.go 11 15 73.33%
Files with Coverage Reduction New Missed Lines %
api/handler/v1beta1/job_run.go 1 73.74%
ext/notify/pagerduty/pagerdutynotifier.go 2 93.75%
job/service.go 2 55.15%
Totals Coverage Status
Change from base Build 2925682963: 0.7%
Covered Lines: 7426
Relevant Lines: 9702
💛 - Coveralls

@Mryashbhardwaj Mryashbhardwaj self-assigned this Aug 24, 2022
arinda-arif
arinda-arif reviewed Aug 24, 2022
View reviewed changes
arinda-arif
arinda-arif reviewed Aug 24, 2022
View reviewed changes
arinda-arif
arinda-arif reviewed Aug 29, 2022
View reviewed changes
arinda-arif
arinda-arif reviewed Aug 29, 2022
View reviewed changes
arinda-arif
arinda-arif reviewed Aug 29, 2022
View reviewed changes
@arinda-arif
Copy link
Contributor

arinda-arif commented Aug 29, 2022

The changes look good. After fixing the coverage and changing the proton commit to the merged one, we can merge this.

irainia
irainia requested changes Sep 2, 2022
View reviewed changes
arinda-arif
arinda-arif reviewed Sep 2, 2022
View reviewed changes
@sravankorumilli sravankorumilli changed the title fix: refactor createJobSpecification feat: add AddJobSpecifications api & refactor createJobSpecification api Sep 2, 2022
@sravankorumilli sravankorumilli merged commit d0f6250 into main Sep 2, 2022
@sravankorumilli sravankorumilli deleted the refactor_createJobSpecification branch September 2, 2022 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@irainia irainia irainia approved these changes

@arinda-arif arinda-arif arinda-arif approved these changes

@sravankorumilli sravankorumilli Awaiting requested review from sravankorumilli

Assignees

@Mryashbhardwaj Mryashbhardwaj

Labels

None yet

Projects

None yet

Milestone

Improve Job Deployment Flow

Development

Successfully merging this pull request may close these issues.

Refactor createJobSpecification api

6 participants

@Mryashbhardwaj @coveralls @arinda-arif @sravankorumilli @irainia