Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: Job Inspect #543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 48 commits into from
Oct 21, 2022
Merged

feat: Job Inspect #543

merged 48 commits into from
Oct 21, 2022

Conversation

@Mryashbhardwaj
Copy link
Member

@Mryashbhardwaj Mryashbhardwaj commented Aug 29, 2022

fixes : #494 #492 #493

@Mryashbhardwaj Mryashbhardwaj requested a review from sbchaos August 29, 2022 05:48
@coveralls
Copy link

coveralls commented Aug 29, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3295386652

  • 77 of 106 (72.64%) changed or added relevant lines in 5 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 80.565%
Changes Missing Coverage Covered Lines Changed/Added Lines %
models/job.go 0 3 0.0%
api/handler/v1beta1/job_spec.go 16 25 64.0%
job/service.go 48 65 73.85%
Files with Coverage Reduction New Missed Lines %
ext/notify/pagerduty/pagerdutynotifier.go 2 93.75%
Totals Coverage Status
Change from base Build 3287481486: -0.1%
Covered Lines: 7905
Relevant Lines: 9812
💛 - Coveralls

This was linked to issues Aug 29, 2022
Provide Optimus Job inspect Command #492
Closed
download rendered job assets via Optimus job inspect command #493
Closed
@Mryashbhardwaj Mryashbhardwaj self-assigned this Aug 29, 2022
Mryashbhardwaj
Mryashbhardwaj commented Sep 22, 2022
View reviewed changes
arinda-arif
arinda-arif reviewed Oct 10, 2022
View reviewed changes
arinda-arif
arinda-arif reviewed Oct 13, 2022
View reviewed changes
arinda-arif
arinda-arif approved these changes Oct 18, 2022
View reviewed changes
Copy link
Contributor

@arinda-arif arinda-arif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. If possible you can add more test cases before merging.

@Mryashbhardwaj
Copy link
Member Author

Mryashbhardwaj commented Oct 18, 2022

LGTM. If possible you can add more test cases before merging.

how about adding more tests after the final refactor

@Mryashbhardwaj Mryashbhardwaj merged commit 7898d83 into main Oct 21, 2022
@Mryashbhardwaj Mryashbhardwaj deleted the job_explain branch October 21, 2022 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arinda-arif arinda-arif arinda-arif approved these changes

@sbchaos sbchaos Awaiting requested review from sbchaos

Assignees

@Mryashbhardwaj Mryashbhardwaj

Labels

None yet

Projects

None yet

Milestone

Improve User Experience - Phase 2

5 participants

@Mryashbhardwaj @coveralls @arinda-arif @sravankorumilli