Thanks to visit codestin.com
Credit goes to github.com

Skip to content

refactor: cleanup minor part 1 #549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 9, 2022
Merged

refactor: cleanup minor part 1 #549

merged 7 commits into from
Sep 9, 2022

Conversation

@deryrahman
Copy link
Member

@deryrahman deryrahman commented Aug 30, 2022

Tracker can be seen here #545

@deryrahman deryrahman linked an issue Aug 30, 2022 that may be closed by this pull request
Cleanup minor tech-debt #545
Closed
11 tasks
@coveralls
Copy link

coveralls commented Aug 30, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3004793202

  • 5 of 9 (55.56%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 76.348%
Changes Missing Coverage Covered Lines Changed/Added Lines %
config/loader.go 5 9 55.56%
Totals Coverage Status
Change from base Build 3000762068: 0.07%
Covered Lines: 7563
Relevant Lines: 9906
💛 - Coveralls

sbchaos
sbchaos reviewed Sep 1, 2022
View reviewed changes
@deryrahman deryrahman marked this pull request as ready for review September 7, 2022 03:10
sbchaos
sbchaos reviewed Sep 8, 2022
View reviewed changes
config/loader.go
)

//nolint:gochecknoinits
func init() { // TODO: move paths initialization outside init()
Copy link
Contributor

@sbchaos sbchaos Sep 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sravankorumilli sravankorumilli merged commit c3bdc90 into main Sep 9, 2022
@sravankorumilli sravankorumilli deleted the cleanup-minor branch September 9, 2022 04:34
deryrahman added a commit that referenced this pull request Oct 17, 2022
@deryrahman
refactor: cleanup minor part 1 (#549)
2f25310 
* refactor: remove loadConfig method

* refactor: remove ToProjectProtoWithSecrets

* refactor: remove init on config loader

* refactor: pass dbconfig on connect postgres

* feat: add logging on close func

* fix: lint

* refactor: remove pointer on load config prerun
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbchaos sbchaos sbchaos approved these changes

@irainia irainia irainia approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cleanup minor tech-debt

6 participants

@deryrahman @coveralls @sbchaos @irainia @sravankorumilli