Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@deryrahman
Copy link
Member

No description provided.

@deryrahman deryrahman linked an issue Sep 2, 2022 that may be closed by this pull request
11 tasks
@coveralls
Copy link

coveralls commented Sep 6, 2022

Pull Request Test Coverage Report for Build 3057976830

  • 18 of 24 (75.0%) changed or added relevant lines in 3 files are covered.
  • 143 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.8%) to 77.063%

Changes Missing Coverage Covered Lines Changed/Added Lines %
utils/validator.go 2 4 50.0%
job/service.go 9 13 69.23%
Files with Coverage Reduction New Missed Lines %
config/loader.go 6 92.41%
ext/notify/slack/slack.go 9 81.5%
api/handler/v1beta1/adapter.go 56 77.04%
models/plugin.go 72 54.76%
Totals Coverage Status
Change from base Build 3000762068: 0.8%
Covered Lines: 7761
Relevant Lines: 10071

💛 - Coveralls

@deryrahman deryrahman marked this pull request as ready for review September 7, 2022 03:11
@deryrahman deryrahman requested a review from irainia September 15, 2022 05:14
@deryrahman deryrahman merged commit 03952e9 into main Sep 15, 2022
@deryrahman deryrahman deleted the cleanup-minor-3 branch September 15, 2022 05:25
deryrahman added a commit that referenced this pull request Sep 15, 2022
* refactor: remove panic when plugin conn fail

* refactor: append err messages

* refactor: safe cast on survey validator

* refactor: add job names

* refactor: return nil

* refactor: return nil
deryrahman added a commit that referenced this pull request Oct 17, 2022
* refactor: remove panic when plugin conn fail

* refactor: append err messages

* refactor: safe cast on survey validator

* refactor: add job names

* refactor: return nil

* refactor: return nil
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cleanup minor tech-debt

4 participants