Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix : backward compatibility in loading yaml plugins #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 8, 2022
Merged

fix : backward compatibility in loading yaml plugins #567

merged 2 commits into from
Sep 8, 2022

Conversation

@smarchone
Copy link
Member

@smarchone smarchone commented Sep 7, 2022

changes:

  • load yaml and binary plugins if available
  • revert plugin discovery logic to dynamic to accommodate discover existing binary plugins at client end

Now, Plugin struct can contain multiple implementations (yaml, bin)
and use-cases can choose what ever implementations as per requirements.

Plugin instances can exists as follows:

  1. Binary imp. only
  2. Binary & Yaml Impl.
  3. Yaml Impl. only

@coveralls
Copy link

coveralls commented Sep 7, 2022

Pull Request Test Coverage Report for Build 3010806181

  • 12 of 14 (85.71%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 76.991%
Changes Missing Coverage Covered Lines Changed/Added Lines %
models/plugin.go 9 11 81.82%
Files with Coverage Reduction New Missed Lines %
models/plugin.go 2 54.76%
Totals Coverage Status
Change from base Build 3007053083: 0.02%
Covered Lines: 7763
Relevant Lines: 10083
💛 - Coveralls

@smarchone smarchone linked an issue Sep 7, 2022 that may be closed by this pull request
fix : support backward compatibility of binary plugins at client end #568
Closed
@sravankorumilli sravankorumilli merged commit f7ef0bd into main Sep 8, 2022
@sravankorumilli sravankorumilli deleted the fix-yaml-plugins branch September 8, 2022 11:06
@smarchone smarchone mentioned this pull request Sep 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sravankorumilli sravankorumilli Awaiting requested review from sravankorumilli

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fix : support backward compatibility of binary plugins at client end

4 participants

@smarchone @coveralls @sravankorumilli