Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: fix sensor to pass version information to compute the start & end times #614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 23, 2022
Merged

fix: fix sensor to pass version information to compute the start & end times #614

merged 1 commit into from
Sep 23, 2022

Conversation

@sravankorumilli
Copy link
Contributor

@sravankorumilli sravankorumilli commented Sep 23, 2022 •
edited
Loading

closes: #613

  1. Removed the invalid validations in the /window endpoint
  2. Updated the defaults for daily task window truncate option to 'd' as part of cli spec.
  3. Server side defaults for truncate is set to '' for version 1

@sravankorumilli sravankorumilli added the bug Something isn't working label Sep 23, 2022
@coveralls
Copy link

coveralls commented Sep 23, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3110549878

  • 2 of 8 (25.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.05%) to 77.68%
Changes Missing Coverage Covered Lines Changed/Added Lines %
models/window_v1.go 2 5 40.0%
models/window_v2.go 0 3 0.0%
Totals Coverage Status
Change from base Build 3088755087: -0.05%
Covered Lines: 7782
Relevant Lines: 10018
💛 - Coveralls

@sravankorumilli sravankorumilli force-pushed the fix/sensor_with_new_job_spec_version branch from b859844 to 2c7ad71 Compare September 23, 2022 05:22
irainia
irainia reviewed Sep 23, 2022
View reviewed changes
@sravankorumilli sravankorumilli merged commit 6b458b4 into main Sep 23, 2022
@sravankorumilli sravankorumilli deleted the fix/sensor_with_new_job_spec_version branch September 23, 2022 13:46
sravankorumilli added a commit that referenced this pull request Sep 23, 2022
@sravankorumilli
fix: fix sensor to pass version information to compute the start & en…
cc661eb 
…d times (#614)
sravankorumilli added a commit that referenced this pull request Sep 23, 2022
@sravankorumilli
fix: fix sensor to pass version information to compute the start & en…
eb9cf80 
…d times (#614) (#617)
deryrahman pushed a commit that referenced this pull request Oct 17, 2022
@sravankorumilli @deryrahman
fix: fix sensor to pass version information to compute the start & en…
3503931 
…d times (#614)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@irainia irainia irainia approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

Improve User Experience

Development

Successfully merging this pull request may close these issues.

Sensors are failing for fetching the window information after introduction the jobspec version 2

4 participants

@sravankorumilli @coveralls @irainia