refactor: add tenant bounded context #619
Conversation
Co-authored-by: Sandeep Bhardwaj <[email protected]>
Pull Request Test Coverage Report for Build 3214991025
💛 - Coveralls |
| } | ||
| } | ||
|
|
||
| func NewTenant(projectName string, namespaceName string) (Tenant, error) { |
There was a problem hiding this comment.
How about we split this into NewProjectScopedTenant && NewNamespaceScopedTenant, it will be explicit & we don't need to ignore the error.
There was a problem hiding this comment.
We will still require the constructor with optional namespace, otherwise the caller will have to make the decision.
There was a problem hiding this comment.
Also adding a new Constructor for namespace mandatory tenant as NewNamespaceTenant
| } | ||
|
|
||
| func (t TenantService) GetDetails(ctx context.Context, tnnt tenant.Tenant) (*tenant.WithDetails, error) { | ||
| if tnnt.ProjectName() == "" { |
There was a problem hiding this comment.
this check is n't needed as tenant won't be created without projectname
| return nil, err | ||
| } | ||
|
|
||
| var namespace *tenant.Namespace |
There was a problem hiding this comment.
lets see if we can avoid this complexity of tenant optional behaviour by keeping things explicit
| return tenant.NewSecret(s.Name, typ, string(encrypted), t) | ||
| } | ||
|
|
||
| func (s Secret) ToSecretInfo() (*dto.SecretInfo, error) { |
There was a problem hiding this comment.
I would suggest to do this in service layer, where repository will always return secrets stored in DB in that case creation of PlainTextSecret & SecretInfo is the responsibility of service layer.
There was a problem hiding this comment.
Secret does not have some of the fields required, we will require a dto to send those values to service.
* refactor: add support for project in tenant bounded context Co-authored-by: Sandeep Bhardwaj <[email protected]> * feat: add test for project handler, service and store * refactor: add test for project and improve errors * refactor: add validation in project * refactor: improve mock to get rid of nil reference error * refactor: use sql for CRUD in project repo * feat: add service, model and handler for namespace * refactor: add namespace repository * feat: add app_key and tenant models * refactor: add secret models * wip: add handler for secrets * refactor: add secret handler and service * refactor: add secret repository * fix: fix lint errors * fix: move new repository test to repository test command * refactor: add tenant service * fix: fix lint error * refactor: wire tenant handlers in optimus server * refactor: remove unused handlers * refactor: move query to usage * refactor: remove unused code * refactor: fix as per feedback comments * fix: fix unit test * refactor: use secrets as pointer and not value type * refactor: add mandatory namespace constructor * refactor: do not expose mocks Co-authored-by: Sravan Korumilli <[email protected]>
No description provided.