fix: replay fix dependency resolution #633
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
71edacd to
52e7236
Compare
Pull Request Test Coverage Report for Build 3262667834
💛 - Coveralls |
arinda-arif
reviewed
Oct 12, 2022
Contributor
arinda-arif
left a comment
There was a problem hiding this comment.
we can go with this change to fix the issue, however, in every replay & backup request, there will be calls to external Optimus to check for each of the unresolved dependencies. we can monitor the performance and later improve this.
fyi @sravankorumilli
Contributor
|
@arinda-arif @SumitAgrawal03071989 after this does it replay for the external jobs ?? |
Contributor
|
@SumitAgrawal03071989 can you link the issue in the pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #632