Thanks to visit codestin.com
Credit goes to github.com

Skip to content

refactor: clean up admin build instance #635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 19, 2022
Merged

refactor: clean up admin build instance #635

merged 8 commits into from
Oct 19, 2022

Conversation

@deryrahman
Copy link
Member

@deryrahman deryrahman commented Oct 11, 2022 •
edited
Loading

  • Remove RegisterInstance on api handler
  • Remove test cases for RegisterInstance
  • Remove command admin build instance on client side
  • Remove register instance repository
  • Deprecate RegisterInstance proto (refactor(optimus): deprecated register instance service proton#201)
  • Remove some parts of optimus docs which relate to RegisterInstance not required, it's part of simplify plugin ecosystem

@coveralls
Copy link

coveralls commented Oct 11, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3278580706

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 16 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.1%) to 80.658%
Files with Coverage Reduction New Missed Lines %
api/handler/v1beta1/adapter.go 2 75.0%
ext/notify/pagerduty/pagerdutynotifier.go 2 93.75%
client/local/specio/job_spec_io.go 12 87.59%
Totals Coverage Status
Change from base Build 3218867138: 0.1%
Covered Lines: 7840
Relevant Lines: 9720
💛 - Coveralls

@deryrahman deryrahman linked an issue Oct 17, 2022 that may be closed by this pull request
Clean up admin build instance api #634
Closed
2 tasks
Mryashbhardwaj
Mryashbhardwaj approved these changes Oct 18, 2022
View reviewed changes
Copy link
Member

@Mryashbhardwaj Mryashbhardwaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deryrahman deryrahman merged commit 6afefe7 into main Oct 19, 2022
@deryrahman deryrahman deleted the clean-up-admin-build-instance branch October 19, 2022 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mryashbhardwaj Mryashbhardwaj Mryashbhardwaj approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Clean up admin build instance api

4 participants

@deryrahman @coveralls @Mryashbhardwaj