Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: deprecate climod compile asset, move to depResMod #639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Nov 7, 2022
Merged

feat: deprecate climod compile asset, move to depResMod #639

merged 11 commits into from
Nov 7, 2022

Conversation

@deryrahman
Copy link
Member

@deryrahman deryrahman commented Oct 17, 2022 •
edited
Loading

Tracker:

@deryrahman deryrahman requested a review from smarchone October 17, 2022 10:59
@deryrahman deryrahman linked an issue Oct 17, 2022 that may be closed by this pull request
Move CompileAssets from CommandLineMod interface to DepResMod #594
Closed
6 tasks
@coveralls
Copy link

coveralls commented Oct 17, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3358925329

  • 8 of 9 (88.89%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 80.891%
Changes Missing Coverage Covered Lines Changed/Added Lines %
compiler/job_input_render.go 0 1 0.0%
Totals Coverage Status
Change from base Build 3335026471: 0.3%
Covered Lines: 7899
Relevant Lines: 9765
💛 - Coveralls

@deryrahman deryrahman force-pushed the climod-compile-asset-deprecation branch from 12a599a to da41c2c Compare October 17, 2022 11:14
@deryrahman deryrahman mentioned this pull request Oct 18, 2022
Closed
@deryrahman deryrahman force-pushed the climod-compile-asset-deprecation branch from 3bbcbf5 to 8695663 Compare October 19, 2022 03:43
@deryrahman deryrahman mentioned this pull request Oct 20, 2022
Merged
@deryrahman deryrahman self-assigned this Oct 20, 2022
smarchone
smarchone requested changes Oct 27, 2022
View reviewed changes
@deryrahman deryrahman force-pushed the climod-compile-asset-deprecation branch from ea74b47 to 2b78e3f Compare October 31, 2022 05:51
@deryrahman deryrahman requested a review from smarchone November 1, 2022 03:10
smarchone
smarchone approved these changes Nov 6, 2022
View reviewed changes
Copy link
Member

@smarchone smarchone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@deryrahman deryrahman merged commit 989cf7a into main Nov 7, 2022
@deryrahman deryrahman deleted the climod-compile-asset-deprecation branch November 7, 2022 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smarchone smarchone smarchone approved these changes

Assignees

@deryrahman deryrahman

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Move CompileAssets from CommandLineMod interface to DepResMod

4 participants

@deryrahman @coveralls @smarchone