Thanks to visit codestin.com
Credit goes to github.com

Skip to content

refactor: mark namespace name mandatory in tenant #643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 3, 2022
Merged

refactor: mark namespace name mandatory in tenant #643

merged 2 commits into from
Nov 3, 2022

Conversation

@sbchaos
Copy link
Contributor

@sbchaos sbchaos commented Oct 19, 2022

No description provided.

@sbchaos sbchaos self-assigned this Oct 19, 2022
@coveralls
Copy link

coveralls commented Oct 19, 2022

Pull Request Test Coverage Report for Build 3278824789

  • 72 of 72 (100.0%) changed or added relevant lines in 5 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.06%) to 80.619%
Files with Coverage Reduction New Missed Lines %
ext/notify/pagerduty/pagerdutynotifier.go 2 93.75%
Totals Coverage Status
Change from base Build 3278589169: -0.06%
Covered Lines: 7820
Relevant Lines: 9700
💛 - Coveralls

@sbchaos sbchaos linked an issue Oct 26, 2022 that may be closed by this pull request
Mark namespace name mandatory for a tenant #642
Closed
2 tasks
sravankorumilli
sravankorumilli reviewed Nov 3, 2022
View reviewed changes
@sravankorumilli sravankorumilli merged commit 1c656de into main Nov 3, 2022
@sravankorumilli sravankorumilli deleted the change-tenant branch November 3, 2022 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sravankorumilli sravankorumilli sravankorumilli left review comments

Assignees

@sbchaos sbchaos

Labels

None yet

Projects

None yet

Milestone

Code restructuring to Domain Oriented

Development

Successfully merging this pull request may close these issues.

Mark namespace name mandatory for a tenant

4 participants

@sbchaos @coveralls @sravankorumilli