From bf4ba8c6c24ea40ded925705b40a096af555846c Mon Sep 17 00:00:00 2001
From: Will Lopez <will.lopez77@gmail.com>
Date: Thu, 12 Sep 2019 17:05:21 -0700
Subject: [PATCH] chore: fix various prop type validation errors

Signed-off-by: Will Lopez <will.lopez77@gmail.com>
---
 imports/client/ui/components/Button/Button.js             | 3 +--
 .../components/DetailDrawerButton/DetailDrawerButton.js   | 2 +-
 .../client/components/OrderCardFulfillmentGroups.js       | 4 ++--
 .../plugins/core/orders/client/components/OrderHeader.js  | 4 ++--
 .../core/orders/client/components/OrderPayments.js        | 2 +-
 .../plugins/core/orders/client/components/OrderRefunds.js | 8 ++++----
 imports/plugins/core/tags/client/components/TagForm.js    | 7 +++----
 imports/plugins/core/tags/client/components/TagToolbar.js | 3 +--
 8 files changed, 15 insertions(+), 18 deletions(-)

diff --git a/imports/client/ui/components/Button/Button.js b/imports/client/ui/components/Button/Button.js
index c6ec71bfb76..e4b7670116a 100644
--- a/imports/client/ui/components/Button/Button.js
+++ b/imports/client/ui/components/Button/Button.js
@@ -6,7 +6,7 @@ import MuiButton from "@material-ui/core/Button";
 
 const styles = (theme) => ({
   buttonProgress: {
-    marginLeft: theme.spacing.unit
+    marginLeft: theme.spacing(1)
   },
   containedPrimary: {
     "color": theme.palette.primary.contrastText,
@@ -85,7 +85,6 @@ Button.defaultProps = {
   disableRipple: false,
   fullWidth: false,
   href: null,
-  mini: false,
   size: "medium",
   variant: "text"
 };
diff --git a/imports/client/ui/components/DetailDrawerButton/DetailDrawerButton.js b/imports/client/ui/components/DetailDrawerButton/DetailDrawerButton.js
index 9d0951b1420..d38dab11f13 100644
--- a/imports/client/ui/components/DetailDrawerButton/DetailDrawerButton.js
+++ b/imports/client/ui/components/DetailDrawerButton/DetailDrawerButton.js
@@ -26,7 +26,7 @@ function DetailDrawerButton(props) {
 
 DetailDrawerButton.propTypes = {
   children: PropTypes.node,
-  component: PropTypes.func
+  component: PropTypes.object
 };
 
 DetailDrawerButton.defaultProps = {
diff --git a/imports/plugins/core/orders/client/components/OrderCardFulfillmentGroups.js b/imports/plugins/core/orders/client/components/OrderCardFulfillmentGroups.js
index f90e75391df..093eaa3d529 100644
--- a/imports/plugins/core/orders/client/components/OrderCardFulfillmentGroups.js
+++ b/imports/plugins/core/orders/client/components/OrderCardFulfillmentGroups.js
@@ -173,7 +173,7 @@ class OrderCardFulfillmentGroups extends Component {
                   <Grid item xs={6} md={6}>
                     <Grid container alignItems="center" spacing={2}>
                       <Grid item>
-                        <Typography variant="h4" inline={true}>
+                        <Typography variant="h4" display="inline">
                           {i18next.t("order.fulfillmentGroupHeader", `Fulfillment group ${currentGroupCount} of ${totalGroupsCount}`)}
                         </Typography>
                       </Grid>
@@ -232,7 +232,7 @@ class OrderCardFulfillmentGroups extends Component {
                         <Typography paragraph variant="h4">
                           {i18next.t("order.trackingNumber", "Tracking number")}
                         </Typography>
-                        <OrderCardFulfillmentGroupTrackingNumber orderId={order._id} fulfillmentGroup={fulfillmentGroup} {...this.props}/>
+                        <OrderCardFulfillmentGroupTrackingNumber orderId={order._id} fulfillmentGroup={fulfillmentGroup} {...this.props} />
                       </Grid>
                     </Grid>
                   </Grid>
diff --git a/imports/plugins/core/orders/client/components/OrderHeader.js b/imports/plugins/core/orders/client/components/OrderHeader.js
index ebff1bf85fa..9bd51a9158a 100644
--- a/imports/plugins/core/orders/client/components/OrderHeader.js
+++ b/imports/plugins/core/orders/client/components/OrderHeader.js
@@ -56,7 +56,7 @@ function OrderHeader(props) {
       <Grid item xs={12}>
         <Grid container alignItems="center" spacing={2}>
           <Grid item>
-            <Typography variant="h3" className={classes.extraEmphasisText} inline={true}>
+            <Typography variant="h3" className={classes.extraEmphasisText} display="inline">
               {i18next.t("order.order", "Order")} - {referenceId}
             </Typography>
           </Grid>
@@ -80,7 +80,7 @@ function OrderHeader(props) {
         </Grid>
       </Grid>
       <Grid item xs={12}>
-        <Typography variant="body1" inline={true}>{i18next.t("order.placed", "Placed")} {orderDate}</Typography>
+        <Typography variant="body1" display="inline">{i18next.t("order.placed", "Placed")} {orderDate}</Typography>
       </Grid>
     </Grid>
   );
diff --git a/imports/plugins/core/orders/client/components/OrderPayments.js b/imports/plugins/core/orders/client/components/OrderPayments.js
index 6f410a56fcb..dc3e0075c72 100644
--- a/imports/plugins/core/orders/client/components/OrderPayments.js
+++ b/imports/plugins/core/orders/client/components/OrderPayments.js
@@ -125,7 +125,7 @@ function OrderPayments(props) {
           <Grid item xs={6} md={6}>
             <Grid container alignItems="center" spacing={2}>
               <Grid item>
-                <Typography variant="h4" inline={true}>
+                <Typography variant="h4" display="inline">
                   Payments
                 </Typography>
               </Grid>
diff --git a/imports/plugins/core/orders/client/components/OrderRefunds.js b/imports/plugins/core/orders/client/components/OrderRefunds.js
index 31b8828d775..00761b0fccf 100644
--- a/imports/plugins/core/orders/client/components/OrderRefunds.js
+++ b/imports/plugins/core/orders/client/components/OrderRefunds.js
@@ -189,7 +189,7 @@ function OrderRefunds(props) {
                                 const paymentAmountAvailableForRefundDisplay = formatMoney(paymentAmountAvailableForRefund, order.currencyCode);
 
                                 return (
-                                  <Grid item xs={12}>
+                                  <Grid item xs={12} key={payment._id}>
                                     <Grid container>
                                       <Grid item xs={6}>
                                         <Typography variant="body1">
@@ -204,9 +204,9 @@ function OrderRefunds(props) {
                                                 {i18next.t("order.availableToRefund")}: {paymentAmountAvailableForRefundDisplay}
                                               </Typography>
                                               {paymentPreviousRefundTotal && paymentPreviousRefundTotal > 0 &&
-                                          <Typography variant="body2">
-                                            {i18next.t("order.previouslyRefunded")}: {paymentPreviousRefundTotalDisplay}
-                                          </Typography>
+                                                <Typography variant="body2">
+                                                  {i18next.t("order.previouslyRefunded")}: {paymentPreviousRefundTotalDisplay}
+                                                </Typography>
                                               }
                                             </Fragment>
                                             :
diff --git a/imports/plugins/core/tags/client/components/TagForm.js b/imports/plugins/core/tags/client/components/TagForm.js
index 43909025d6b..994da548906 100644
--- a/imports/plugins/core/tags/client/components/TagForm.js
+++ b/imports/plugins/core/tags/client/components/TagForm.js
@@ -86,9 +86,9 @@ class TagForm extends Component {
   }
 
   static defaultProps = {
-    onCancel() {},
-    onCreate() {},
-    onUpdate() {},
+    onCancel() { },
+    onCreate() { },
+    onUpdate() { },
     tag: {}
   }
 
@@ -311,7 +311,6 @@ class TagForm extends Component {
         <HeroUploadButton>
           <Button
             variant="outlined"
-            actionType="secondary"
             color="secondary"
             size="small"
             onClick={this.handleDropzoneClick}
diff --git a/imports/plugins/core/tags/client/components/TagToolbar.js b/imports/plugins/core/tags/client/components/TagToolbar.js
index 9d661a80d6d..8c106cf0aad 100644
--- a/imports/plugins/core/tags/client/components/TagToolbar.js
+++ b/imports/plugins/core/tags/client/components/TagToolbar.js
@@ -16,14 +16,13 @@ function TagToolbar(props) {
     <PrimaryAppBar title={title}>
       {(canBeDeleted) &&
         <Button
-          actionType="secondary"
           isTextOnly={true}
           onClick={onDelete}
         >
           {i18next.t("admin.tags.form.delete")}
         </Button>
       }
-      <Button variant="outlined" actionType="secondary" onClick={onCancel}>
+      <Button variant="outlined" onClick={onCancel}>
         {i18next.t("admin.tags.form.cancel")}
       </Button>
       <Button variant="contained" color="primary" onClick={onSave}>