Implement kernel sanitizers #8435
Open
+1,980
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HBelusca
reviewed
Oct 24, 2025
Contributor
HBelusca
left a comment
There was a problem hiding this comment.
- Some questions;
- space fixes for e1000 changes
dea19c4 to
bb280a7
Compare
tkreuzer
reviewed
Oct 27, 2025
Comment on lines
+827
to
+847
|
|
||
| ASSERT(pData); | ||
|
|
||
| HandleOverflow(false, pData, ulLHS, ulRHS, PLUS_STRING); |
Contributor
There was a problem hiding this comment.
What's the reason for these being wrappers?
Contributor
Author
There was a problem hiding this comment.
__ubsan_handle_add_overflow/__ubsan_handle_add_overflow_abort/ __ubsan_handle_divrem_overflow/ __ubsan_handle_divrem_overflow_abort/... functions are called by the code generated by the compiler. They all call the same function HandleOverflow.
sdk/lib/ksanitize/ubsan.c
Outdated
Comment on lines
102
to
140
| /* | ||
| #include <sys/cdefs.h> | ||
| #if defined(_KERNEL) | ||
| __KERNEL_RCSID(0, "$NetBSD: ubsan.c,v 1.10 2020/03/08 21:35:03 kamil Exp $"); | ||
| #else | ||
| __RCSID("$NetBSD: ubsan.c,v 1.10 2020/03/08 21:35:03 kamil Exp $"); | ||
| #endif | ||
| #if defined(_KERNEL) | ||
| #include <sys/param.h> | ||
| #include <sys/types.h> | ||
| #include <sys/stdarg.h> | ||
| #define ASSERT(x) KASSERT(x) | ||
| #else | ||
| #if defined(_LIBC) | ||
| #include "namespace.h" | ||
| #endif | ||
| #include <sys/param.h> | ||
| #include <assert.h> | ||
| #include <inttypes.h> | ||
| #include <math.h> | ||
| #include <signal.h> | ||
| #include <stdarg.h> | ||
| #include <stdbool.h> | ||
| #include <stdint.h> | ||
| #include <stdio.h> | ||
| #include <stdlib.h> | ||
| #include <string.h> | ||
| #include <syslog.h> | ||
| #include <unistd.h> | ||
| #if defined(_LIBC) | ||
| #include "extern.h" | ||
| #define ubsan_vsyslog vsyslog_ss | ||
| #define ASSERT(x) _DIAGASSERT(x) | ||
| #else | ||
| #define ubsan_vsyslog vsyslog_r | ||
| #define ASSERT(x) assert(x) | ||
| #endif | ||
| */ |
Contributor
There was a problem hiding this comment.
Do we need to keep this? I get that this file is "synced", but how much of it is really still original? Wouldn't it make sense to simply fork it?
Contributor
Author
There was a problem hiding this comment.
Everything is original, except this #ifdef __REACTOS__
58537b7 to
defea0a
Compare
Add SANITIZE_UB switch for enabling -fsanitize=undefined on binaries
defea0a to
7dbc0ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Implement kernel sanitizers (
-fsanitize=...)This is a resurrection of PR #2527
JIRA issue: CORE-15771
Proposed changes
SANITIZE_UBto enable kernel undefined sanitizersdk/lib/ksanitizehaving required functionsntoskrnl,hal, drivers...) toksanitizelibraryTODO
Testbot runs (Filled in by Devs)