[URLMON] Fix compilation regression while using Fedora #8441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch causes a redefined error, removing because I cannot compile with Fedora Reverted hash 6b3406e
Author
Author
|
i am working on it, i just broke stuff with a command i'm recloning and recommitting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Compilation didn't work on Fedora Linux, but it worked on Debian (for whatever reason). Is that what i get for being a Fedora user?
Apparently (i just ChatGPT'd it, i really don't know how CMake works) assigning multiple values to a flag is very wrong, and that is proven by the compilation errors.
In the faulty commit there are 11 items, when compiling it spits out 10 "error: "PROXY_CLSID_IS" REDEFINED [-Werror]"; if i put 3 items it spits out 2 errors; if i put 1 item it compiles just fine.
It would be ideal to somehow actually fix the PR but judging by the way it is set up I don't think it's worth it, since it really looks like a hackfix...!!
JIRA issue: CORE-XXXX
Proposed changes
That patch actually improved some tests, but i just can't figure out how rostests work so... i guess i'm gonna push this since i literally need to revert it locally to compile
Thanks to user hpoussin for actually finding the fix, I just decided to make a PR out of it
Testbot runs (Filled in by Devs)