Thanks to visit codestin.com
Credit goes to github.com

Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: uber-go/zap
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: reddit/zap
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 2 commits
  • 78 files changed
  • 1 contributor

Commits on Dec 3, 2020

  1. Add NumbersAsStrings to EncoderConfig

    This partially fixes #884.
    
    This implementation is limited to top level fields, like:
    
        Int64("int64", 123)
        Float64("float64", 456)
    
    Or sugared:
    
        With("int64", 123, "float64", float64(456), "slice", []int{1, 2, 3})
    
    It does NOT work with reflected fields like:
    
        Reflect("slice", []int{1, 2, 3})
        With("struct", struct{ Int64 int64 }{Int64: 123})
    
    As for reflected fields we use go's stdlib json encoder directly, which
    doesn't provide such feature.
    fishy committed Dec 3, 2020
    Configuration menu
    Copy the full SHA
    0d6cec9 View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2020

  1. Change import path

    Just doing
    
        go mod edit --replace=go.uber.org/zap=github.com/reddit/[email protected]
    
    In Baseplate.go won't cause all the go.mod files in services importing
    Baseplate.go to do the same replacement, so although it works for
    Baseplate.go, the service code won't build.
    
    We have to change all the import path inside this repo into
    github.com/reddit/zap so that we can change the import from
    go.uber.org/zap into github.com/reddit/zap in Baseplate.go.
    fishy committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    de5493d View commit details
    Browse the repository at this point in the history
Loading