This repository was archived by the owner on Aug 2, 2025. It is now read-only.
fix: context binding in addModel #873
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
semoal
suggested changes
Mar 1, 2021
packages/core/test/init.test.ts
Outdated
| }) | ||
| }) | ||
|
|
||
| test('addModel works when it was used alone', () => { |
Member
There was a problem hiding this comment.
move this test better to store.test.ts please, we already have there some tests related to storeModel =)
semoal
approved these changes
Mar 1, 2021
tianzhich
approved these changes
Mar 2, 2021
Collaborator
|
Looks great! The |
Collaborator
|
I merged, you can publish in your free time @semoal |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for issue #872