Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Aug 2, 2025. It is now read-only.

fix: make models on init() Partial<T> #892

Merged
merged 1 commit into from
May 14, 2021
Merged

fix: make models on init() Partial<T> #892

merged 1 commit into from
May 14, 2021

Conversation

@semoal
Copy link
Member

@semoal semoal commented May 13, 2021

https://github.com/rematch/rematch/pull/891/files#diff-1f8711ffcf4ef0b26aea69d164072937102d5109ecfd8790b6e879c7421e00d3

Since I've checked how it's the strategy with typescript and addModel, has sense to define a RootModel which is Partial of a complete RootModel.

import { Models } from '@rematch/core'
import { players } from './players'
import { settings } from './settings'
import { cart } from './cart'

export interface RootModel extends Models<RootModel> {
	players: typeof players
	cart: typeof cart
	settings: typeof settings
}

export const models: Partial<RootModel> = { players, cart }

In this way we can define the complete typings but a FUTURE usage, but the current models isn't complete yet.

@semoal semoal requested a review from tianzhich May 13, 2021 21:20
@github-actions
Copy link

github-actions bot commented May 13, 2021

size-limit report 📦

Path Size
./packages/core/dist/core.umd.production.min.js 1.42 KB (0%)
./packages/immer/dist/immer.umd.production.min.js 143 B (0%)
./packages/loading/dist/loading.umd.production.min.js 596 B (0%)
./packages/persist/dist/persist.umd.production.min.js 172 B (0%)
./packages/select/dist/select.umd.production.min.js 456 B (0%)
./packages/updated/dist/updated.umd.production.min.js 407 B (0%)

tianzhich
tianzhich reviewed May 14, 2021
View reviewed changes
Copy link
Collaborator

@tianzhich tianzhich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am still not sure why we need to partialize the defined rootModels. If we don't use this model, we should also remove its typing? Could you explain more clearly mate?

@tianzhich
Copy link
Collaborator

tianzhich commented May 14, 2021

I seem to understand your opinion. Do you want to fix the dynamically added model's typing problem? I guess you want to define it's types before you add it dynamically. So there will no typing problem after it is added. Am I right?

@semoal
Copy link
Member Author

semoal commented May 14, 2021

I seem to understand your opinion. Do you want to fix the dynamically added model's typing problem? I guess you want to define it's types before you add it dynamically. So there will no typing problem after it is added. Am I right?

Exactly that

tianzhich
tianzhich approved these changes May 14, 2021
View reviewed changes
Copy link
Collaborator

@tianzhich tianzhich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I think that's well for dynamically adding features. Good job mate  👍

@semoal semoal changed the title fix: make models on init also Partial<T> fix: make models on init() Partial<T> May 14, 2021
@semoal semoal merged commit 991a9d8 into main May 14, 2021
@semoal semoal deleted the fix-partial branch May 14, 2021 10:53
@semoal semoal mentioned this pull request May 25, 2021
Closed
15 tasks
@tianzhich tianzhich mentioned this pull request May 26, 2021
Merged
5 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@tianzhich tianzhich tianzhich approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@semoal @tianzhich