rename redis_key to resque_loner_redis_key #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to avoid clashing in case redis_key is used by something else an example is resque-restriction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just had a fun time debugging a weird behavior when using both resque-restriction and resque-loner in the same job. It turned out both plugins use and provide an implementation for a
redis_keymethod, but due to the nature of each plugin, the implementations are not compatible. resque-restriction needs the key to identify a group of jobs, whereas resque-loner needs the key to identify a single jobI think it would be nice if each plugin uses a name that's more specific to itself. What do you think?
This PR is not addressing backward compatibility. If you like the idea maybe we can discuss more. One way is to only release this in a major version upgrade