Support Trilogy #447
Merged
Support Trilogy #447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trilogy returns an `Enumerator` from `Trilogy::Result#each`. So `each.length` can't check the value correctly.
af78a88 to
105de06
Compare
|
v2.0.0.beta2 has been released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub introduced a client library for MySQL-compatible called Trilogy.
https://github.blog/2022-08-25-introducing-trilogy-a-new-database-adapter-for-ruby-on-rails/
Rails 7.1 introduces the adapter for Trilogy officially.
https://guides.rubyonrails.org/7_1_release_notes.html#introduce-adapter-for-trilogy
This PR adds Trilogy support to
ridgepole. This PR only considers Rails 7.1 because Rails added the official support in the version.But, the Trilogy team provides the gem to support old Rails versions. trilogy-libraries/activerecord-trilogy-adapter. If we need it, I will add support to this gem too.