Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Feb 24, 2020. It is now read-only.
This repository was archived by the owner on Feb 24, 2020. It is now read-only.

rkt errors out when /dev/log exists in the image #2301

@yifan-gu

Description

@yifan-gu

After #2224
rkt will error out when the /dev/log exists in the image. e.g.

$ rkt run --insecure-options=image docker://gcr.io/google_containers/skydns:2015-10-13-8c72f8cimage: using image from local store for image name coreos.com/rkt/stage1-coreos:1.1.0+gitb00ba40
image: using image from local store for url docker://gcr.io/google_containers/skydns:2015-10-13-8c72f8c
networking: loading networks from /etc/rkt/net.d
networking: loading network default with type ptp
Error: Failed to create /dev/log symlink: File exists

Turns out the image prepares its own /dev/log:

$ ls -al skydns/rootfs/dev/
total 48
drwxr-xr-x  3 root root 4096 May 22  2014 .
drwxr-xr-x 18 root root 4096 Jan  1  1970 ..
crw--w--w-  1 root root 5, 1 May 22  2014 console
lrwxrwxrwx  1 root root   13 Jan  1  1970 fd -> /proc/self/fd
lrwxrwxrwx  1 root root   10 Feb 27  2014 log -> ../tmp/log
drwxrwxr-x  2 root root 4096 Feb 27  2014 pts
lrwxrwxrwx  1 root root   12 Jan  1  1970 stderr -> /dev/console
lrwxrwxrwx  1 root root   15 Jan  1  1970 stdin -> /proc/self/fd/0
lrwxrwxrwx  1 root root   12 Jan  1  1970 stdout -> /dev/console

So what should we do in this case? Should we override the file or leave it as is?

IMO I think we should leave it as is while printing a warning message. What do you guys think? @alban @iaguis

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions