-
Notifications
You must be signed in to change notification settings - Fork 76
Closed
Labels
Description
Prework
- Read and agree to the code of conduct and contributing guidelines.
- Confirm that your issue is most likely a genuine bug in the
targets
package itself and not a user error or known limitation. For usage issues and troubleshooting, please post to the discussions instead. - If there is already a relevant issue, whether open or closed, comment on the existing thread instead of posting a new issue.
- Post a minimal reproducible example like this one so the maintainer can troubleshoot the problems you identify. A reproducible example is:
- Runnable: post enough R code and data so any onlooker can create the error on their own computer.
- Minimal: reduce runtime wherever possible and remove complicated details that are irrelevant to the issue at hand.
- Readable: format your code according to the tidyverse style guide.
Description
Shows up in complicated cases when a pattern is up to date but is temporarily considered "running" until all the branches are checked. Should handle with a new target_patternview_running()
method that calls patternview_register_running()
on the parent in a branch (and does nothing in all other target classes). target_patternview_running()
should be called in target_prepare.tar_builder()
. We can then remove patternview_register_running()
from pattern_conclude_initial()
and progress monitoring should be the same as before (except not over eager).