updated ros-tooling versions #407
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan Staschulat <[email protected]>
Signed-off-by: Jan Staschulat <[email protected]>
Signed-off-by: Jan Staschulat <[email protected]>
|
Remark: ament_uncrustify seems to be different for ...
regards only two source files:
If no changes are made regarding ament_uncrustify then ROS pipeline fails (regarding ament_uncrustify) and Github Pipeline is successful. |
pablogs9
approved these changes
Sep 24, 2024
It might be because GitHub CI here is using Ubuntu 22.04, while ROS CI is using Ubuntu 24.04. So they probably have different versions of uncrustify. Since Rolling and Jazzy use Ubuntu 24.04 now, you should change the CI config to use Ubuntu 24.04 too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #406
Maybe a solution is to update the ros-tooling versions.