Throw exception if attempting to use cvc4 with a multi-solver engine #274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lonsing
approved these changes
Jun 1, 2021
| // used for setting solver options appropriately | ||
| }; | ||
|
|
||
| // NOTE keep this up to date so that setting |
There was a problem hiding this comment.
Please update also the comment in lines 42-44 above to refer to ic3_variants_set in ./options/options.cpp, which must be updated when adding IC3 variants.
There was a problem hiding this comment.
Good catch! Fixed in e847cde.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR would throw an exception if trying to use CVC4 with an engine that uses multiple instances of the solver. This is only temporary until the multi-solver issues in CVC4 are resolved.