Fix push/pop mismatch in array_axioms_refiner #201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmed-irfan
reviewed
Jan 15, 2021
|
|
||
| if (!found_lemmas) { | ||
| // there appears to be a concrete counterexample | ||
| solver_->pop(); |
There was a problem hiding this comment.
we may want to store the counterexample. Where do we do that? If we pop now, we will not have access to the model values.
There was a problem hiding this comment.
That's a good point. I believe it's currently not handled at all (I don't think witnesses were handled before either). I'm not sure that's the right place anyway though since it's in the refiner. Maybe we should unroll the concrete transition system to get the trace when there's a counterexample? And if we want to save abstract model values to help guide it we could do that too, but there's currently no infrastructure for that. Btw, witness should probably be overridden in CegProphecyArrays so that it returns the right witness there.
ahmed-irfan
approved these changes
Jan 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this never showed up before because we never used to continue execution after finding a counterexample. But now that we can have nested CEGAR loops, this is important.
Btw, we should probably discuss a better way of keeping track of solver contexts. I'm considering adding this to either smt-switch or having a wrapper solver that keeps track of extra info like that.