Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@makaimann
Copy link
Collaborator

The cutoff is the magnitude of a value that will be abstracted. Anything of lower magnitude will be kept precise.

@makaimann makaimann added the enhancement New feature or request label Jan 18, 2021
@makaimann makaimann requested a review from ahmed-irfan January 18, 2021 20:23
"",
"cegp-abs-vals-cutoff",
Arg::Numeric,
" --cegp-abs-vals-cutoff \tcutoff value for what to abstract (must be "
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't we also print the default value? (which I think is 100)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! Made change with c1f5d53.

Copy link
Collaborator

@ahmed-irfan ahmed-irfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Only one minor comment

@ahmed-irfan ahmed-irfan merged commit f22c280 into master Jan 19, 2021
@ahmed-irfan ahmed-irfan deleted the cegp-abs-val-cutoff branch January 19, 2021 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants