Thanks to visit codestin.com
Credit goes to github.com

Skip to content

mc-interp: refactor #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 14, 2020
Merged

mc-interp: refactor #53

merged 7 commits into from
Jul 14, 2020

Conversation

@ahmed-irfan
Copy link
Collaborator

No description provided.

@ahmed-irfan ahmed-irfan requested a review from makaimann July 10, 2020 23:35
makaimann
makaimann previously approved these changes Jul 11, 2020
View reviewed changes
Copy link
Collaborator

@makaimann makaimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Did you try it on the simple examples at least? It all should be correct (because transA_ shouldn't change -- just want to make sure.

@ahmed-irfan ahmed-irfan changed the title mc-interp: minor cleanup mc-interp: refactor Jul 11, 2020
@ahmed-irfan ahmed-irfan requested a review from makaimann July 11, 2020 06:03
@ahmed-irfan
Copy link
Collaborator Author

I went on refactoring the code to simplify it. This would require a deep review.

@ahmed-irfan ahmed-irfan reopened this Jul 11, 2020
@ahmed-irfan ahmed-irfan dismissed makaimann’s stale review July 11, 2020 09:13

modified the PR. Need a fresh review now

makaimann
makaimann approved these changes Jul 12, 2020
View reviewed changes
Copy link
Collaborator

@makaimann makaimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for this refactor! I'm going to run it on the cluster just to make sure. My jobs are kinda backed up now so it might not be done for a day or so. I'll approve but mark this as do-not-merge for now.

@makaimann makaimann added the do not merge Don't merge this pull request yet (waiting on something or not yet ready). label Jul 12, 2020
@makaimann
Copy link
Collaborator

Screen Shot 2020-07-13 at 11 40 14 AM

Screen Shot 2020-07-13 at 11 41 47 AM

Looks good! Even picked up a few new benchmarks. There was an error, which looks like it might have been in MathSAT? It was malloc(): unsorted double linked list corrupted in adding.3.prop1-func-interl.btor2. There's also one error (segfault) in the baseline, so I'm not sure if we should worry about it too much. What do you think?

@ahmed-irfan
Copy link
Collaborator Author

I think we can merge.

@makaimann makaimann mentioned this pull request Jul 14, 2020
Open
@makaimann makaimann removed the do not merge Don't merge this pull request yet (waiting on something or not yet ready). label Jul 14, 2020
@makaimann makaimann merged commit a25ae2f into stanford-centaur:master Jul 14, 2020
@ahmed-irfan ahmed-irfan deleted the interp-mc-minor-cleanup branch July 14, 2020 00:42
lonsing pushed a commit to lonsing/pono that referenced this pull request Sep 1, 2020
@ahmed-irfan
mc-interp: refactor (stanford-centaur#53)
14667ee 
* minor

* refactor interp-mc

* remove unroller initialization

* clang format

* minor

* minor refactor

* minor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@makaimann makaimann makaimann approved these changes

Assignees

@makaimann makaimann

Labels

refactor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ahmed-irfan @makaimann