Add illuminate/support dependency
#97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds
illuminate/supportas an explicit dependency for the Statamic CLI.By requiring it explicitly, it ensures that the
collect()function is available, which we use in our "do you want to setup a database" prompt.When we tested the database prompt before release, we probably had other global Composer dependencies installed which required
illuminate/support, makingcollect()available. However, if you don't have any other global dependencies installed, you might have seen aCall to undefined function Statamic\Cli\Concerns\collect()error.Fixes #96.