satellite/metabase: partially revert optimizations for precommitDeleteUnversioned

mniewrzal · Storj Robot · commit 61f384fab4e1 · 2025-10-14T11:26:46.000Z
Recently, we made some changes around precommitDeleteUnversioned.
One, to reduce lock wait times during uploads. Second, to fix issue
where committed object end up with negative version after copy/move
operation or one more case where delete marker could have negative version.

We mixed those changes as a one commit but now we need to revert
only optimization because it has some weird side effects on Spanner.

Change-Id: I87a5e7fe2fdbccd20b77068487fc845ce91de496
diff --git a/satellite/metabase/precommit.go b/satellite/metabase/precommit.go
@@ -482,7 +482,7 @@ func (stx *spannerTransactionAdapter) precommitDeleteUnversioned(ctx context.Con
 		SQL: `
 				SELECT version, status
 				FROM objects
-				WHERE (project_id, bucket_name, object_key) = (@project_id, @bucket_name, @object_key) and version > 0
+				WHERE (project_id, bucket_name, object_key) = (@project_id, @bucket_name, @object_key)
 				ORDER BY version DESC
 				LIMIT 1
 			`,
@@ -513,7 +513,6 @@ func (stx *spannerTransactionAdapter) precommitDeleteUnversioned(ctx context.Con
 				project_id      = @project_id
 				AND bucket_name = @bucket_name
 				AND object_key  = @object_key
-				AND version > 0
 				AND status IN ` + statusesUnversioned + `
 			THEN RETURN stream_id, retention_mode, retain_until`,
 		Params: map[string]any{
