Fixes issue with versioning stuck at 1.4.0 for version cloned with git. #762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
2 tasks
2 tasks
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling from source with the repo, the tags of 1.5.0 and v1.5.1 were not annotated (-a flag when generated the tag) and thus did not show up when using the git describe command. Adding the --tag option considers all tag names and allowed versions 1.5.0 and v1.5.1 to be parsed. See https://git-scm.com/docs/git-describe.
The other change was made to remove the leading v if the tag name contained one. This was done as the code in each utility prints out a leading v already, assuming the version was just a number. Version 1.5.1 was tagged as v1.5.1 necessitating this change.