Fix Syntax Errors in Remote Module Code Concatenation #14728
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes syntax errors in remote module transformation when .remote.js files end without a trailing semicolon, space, or newline.
Fixes #14726
Problem
Remote module transformation fails with syntax errors when the source file ends with an expression or a comment and lacks a trailing semicolon, space, or newline.
This causes the concatenated output to become invalid JavaScript.
Example of the Problem:
Root Cause
When Vite transforms .remote.js files, it concatenates the generated code directly with the original module.
If the original file ends with an expression (e.g. console.log) or a comment without a trailing newline, the combined code breaks syntax validity.
Fix
Ensure safe concatenation by adding a newline (or other delimiter) between the transformed code and the original module content.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits