Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update for LLVM 6.0.0 #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yuleisui merged 3 commits into from
Mar 20, 2018
Merged

Update for LLVM 6.0.0 #38

yuleisui merged 3 commits into from
Mar 20, 2018

Conversation

@jackanth
Copy link
Contributor

@jackanth jackanth commented Mar 17, 2018

Relevant LLVM changes for updating to v6.0.0 from v4.0.0:

  • The IsPostDominators member of llvm::DominanceFrontierBase has become a template parameter (https://reviews.llvm.org/D35315).
  • The method llvm::Function::getArgumentList has been dropped in favour of llvm::Function::arg_begin, llvm::Function::arg_end and llvm::Function::args (https://reviews.llvm.org/rL298010).
  • tool_output_file has been renamed ToolOutputFile.
  • FindAllocaDbgDeclare has been replaced with FindDbgAddrUses, which returns a list of zero or one llvm.dbg.declare intrinsics plus zero or more llvm.dbg.addr intrinsics (upcast as DbgInfoIntrinsic objects) (https://reviews.llvm.org/D37768).

I've run the test script for the mem_leak directory and it all looks fine – could you advise any further testing that needs to be done?

Many thanks!
Jack

@jackanth jackanth force-pushed the LLVM-6 branch 2 times, most recently from c3541a3 to 10f28a8 Compare March 17, 2018 11:42
@jackanth
Copy link
Contributor Author

jackanth commented Mar 17, 2018

Re Travis: I'm not sure how much luck we'll have getting LLVM/clang 6 on Ubuntu Trusty – if necessary, we can make a docker container with everything we need and Travis can build SVF inside it.

@yuleisui
Copy link
Collaborator

yuleisui commented Mar 17, 2018

Jack,

Very good! Thanks a lot for your contribution!

I will take a look at the patch next week. It seems no significant changes made compared to 5.0.

By the way, you can also try PTABen (https://github.com/SVF-tools/PTABen) to validate the correctness (e.g., basic_c_tests). Simply copy the benchmark suite under SVF and execute "runtest.sh".

@mbarbar
Mohamad,

Could you please help Jack to set up the travis?

Thanks,
Yulei

yuleisui
yuleisui reviewed Mar 20, 2018
View reviewed changes
Copy link
Collaborator

@yuleisui yuleisui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jack,

The whole patch looks good to me. It has passed all micro-benchmarks.

I will merge it soon.

@yuleisui yuleisui merged commit 9b5c540 into SVF-tools:master Mar 20, 2018
@jackanth
Copy link
Contributor Author

jackanth commented Mar 20, 2018

Great, cheers Yulei!

yuleisui added a commit that referenced this pull request Aug 30, 2019
@yuleisui
Merge pull request #38 from MingshanJia/stage-IFDS
0d3baec 
Mingshan's IFDS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yuleisui yuleisui yuleisui left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jackanth @yuleisui