Fix manual file generation and include trailing newlines in accordance with POSIX [AP-3048] #1453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbmueller
commented
Oct 22, 2024
161c317 to
6e333c7
Compare
pcrumley
reviewed
Oct 22, 2024
| @@ -25,6 +25,7 @@ | |||
| variable_end_string = ')))', | |||
| comment_start_string = '((=', | |||
| comment_end_string = '=))', | |||
| keep_trailing_newline=True, | |||
ec0b2bf to
4a0c321
Compare
`tox-run-command` was missing from the dependency list and is also not compatible with newer versions of tox
4a0c321 to
4d5836e
Compare
774db0c to
4d5836e
Compare
Contributor
Author
|
I can't modify the Dockerfile since the "build docker image" stage always fails when installing the Python dependencies :( |
|
Madhunika-atmakuri
approved these changes
Oct 25, 2024
Contributor
Madhunika-atmakuri
left a comment
There was a problem hiding this comment.
LGTM. Thanks @sbmueller
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@swift-nav/algint-team
API compatibility
Does this change introduce a API compatibility risk?
No, this change is only fixing non-functional issues in the project.
API compatibility plan
If the above is "Yes", please detail the compatibility (or migration) plan:
JIRA Reference
https://swift-nav.atlassian.net/browse/AP-3048