feat: add pdf preview with pdftoppm
#18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks for the PR! I'm also thinking of adding PDF preview functionality to yazi, via (The image taken from Telescope-media-files.nvim) Displaying images is not an issue, yazi aims to provide a more modern interactive experience with multiple image protocols built-in and covering most terminals. And with the pre-caching mechanism, rendering PDF images will not take much time. 😆 |
Contributor
Author
|
That seems to be charming, I might make it work! |
pdftoppm
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add functionality to preview pdf as text with
pdftotext, I am not sure how it behaves on a system withoutpdftotext. The command line arguments are borrowed from ranger.