Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: include ignored files on search when hidden files are shown #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 24, 2023
Merged

feat: include ignored files on search when hidden files are shown #212

merged 1 commit into from
Sep 24, 2023

Conversation

@PhotonQuantum
Copy link
Contributor

@PhotonQuantum PhotonQuantum commented Sep 23, 2023 •
edited
Loading 

  -I, --no-ignore
          Show search results from files and directories that would otherwise be ignored by
          '.gitignore', '.ignore', '.fdignore', or the global ignore file. The flag can be
          overridden with --ignore.

@sxyazi
Copy link
Owner

sxyazi commented Sep 23, 2023

Currently, opt.hidden only represents Yazi's "hidden mode", which simply checks if a file starts with a .. It does not take into account .gitignore.

Therefore, to ensure consistency in this behavior, should it not be --no-ignore instead of --ignore when !opt.hidden is true?

@sxyazi
Copy link
Owner

sxyazi commented Sep 24, 2023

Thank you!

Merge first, and later, we will create fd and rg as independent plugins to provide users with finer control over the parameters.

@sxyazi sxyazi merged commit e2ead7e into sxyazi:main Sep 24, 2023
@PhotonQuantum
Copy link
Contributor Author

PhotonQuantum commented Sep 24, 2023

Therefore, to ensure consistency in this behavior, should it not be --no-ignore instead of --ignore when !opt.hidden is true?

It's really confusing but fd --hidden means including hidden files while --ignore means excluding ignored files in fd and rg.

@PhotonQuantum PhotonQuantum deleted the feat-search-ignore-inherit-hidden branch September 24, 2023 23:55
@branchvincent branchvincent mentioned this pull request Oct 21, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@PhotonQuantum @sxyazi