fix: Windows build and add github action #228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ndtoan96
commented
Sep 30, 2023
- Fix Build breaks on Windows #227
- Add github action
Owner
|
This is so fast! I'm still struggling with Rust ownership, and you've already fixed it, unbelievable! 🙀 BTW, I tried so many ways and couldn't make it work. I'm curious if there's any way to handle it without moving |
Contributor
Author
|
I whink we can call |
Owner
|
Merge first, this piece of code will soon be replaced by Lua. 🤣 |
sxyazi
pushed a commit
that referenced
this pull request
Sep 30, 2023
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.