Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@ndtoan96
Copy link
Contributor

@ndtoan96 ndtoan96 commented Oct 1, 2023

Recording.2023-10-01.095701.mp4

@ndtoan96
Copy link
Contributor Author

ndtoan96 commented Oct 1, 2023

They keymap for this one is weird. My hand keeps pressing n and N out of reflex 😅.

@sxyazi
Copy link
Owner

sxyazi commented Oct 1, 2023

Discussed with @magnetophon at Discord last time, changing the finding key to n/N to keep with Vim's conventions.

https://discord.com/channels/1136203602898194542/1136203604076802092/1156661656638734396

@sxyazi sxyazi changed the title Loop through search result feat: loop through to find Oct 1, 2023
@sxyazi
Copy link
Owner

sxyazi commented Oct 1, 2023

I made some simplifications and removed the previous tedious and lengthy iterators.

BTW, I just found out about is_some_and today, it can help me simplify a lot of map_or(false, ...), really like it!

@sxyazi sxyazi merged commit 73b9c62 into sxyazi:main Oct 1, 2023
@magnetophon
Copy link

magnetophon commented Oct 1, 2023

Discussed with @magnetophon at Discord last time, changing the finding key to n/N to keep with Vim's conventions.

https://discord.com/channels/1136203602898194542/1136203604076802092/1156661656638734396

When I run the main branch, on commit e7eb459, next/previous is still bound to -/=, instead of 'n/N.
I renamed ~/.config/yazi/, so afaik I'm running the default config.
Also: I can't find a relevant occurrence of N in the diff of this PR.

The wrapping is a nice feature and works great, thanks!

@sxyazi
Copy link
Owner

sxyazi commented Oct 2, 2023

Hey @magnetophon, this PR doesn't include the key changes. Sorry for the misunderstanding, and I will create a new PR to complete it.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants