Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: add display_name to opener #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 7, 2023
Merged

feat: add display_name to opener #31

merged 2 commits into from
Aug 7, 2023

Conversation

@XYenon
Copy link
Contributor

@XYenon XYenon commented Aug 7, 2023

No description provided.

@sxyazi
Copy link
Owner

sxyazi commented Aug 7, 2023

I think the name may be confused with the command name, can you change it to display, or something else?

@XYenon
Copy link
Contributor Author

XYenon commented Aug 7, 2023

I think the name may be confused with the command name, can you change it to display, or something else?

I feel display confused too. What about display_name or description?

@sxyazi
Copy link
Owner

sxyazi commented Aug 7, 2023

display_name should make sense. 😆

@sxyazi
Copy link
Owner

sxyazi commented Aug 7, 2023

Thanks, merged!

@sxyazi sxyazi merged commit 2ac51fa into sxyazi:main Aug 7, 2023
@sxyazi sxyazi changed the title feat: add name to opener and show opener's args feat: add display_name to opener Aug 7, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@XYenon @sxyazi