Thanks to visit codestin.com
Credit goes to github.com

Skip to content

ci: add Rust target "aarch64-unknown-linux-gnu" to release workflow #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 27, 2023
Merged

ci: add Rust target "aarch64-unknown-linux-gnu" to release workflow #326

merged 1 commit into from
Oct 27, 2023

Conversation

@nifr
Copy link
Contributor

@nifr nifr commented Oct 27, 2023

This PR adds aarch64-unknown-linux-gnu as Rust target in order to have binary releases for linux/arm64 in the future.

See #325

@nifr nifr force-pushed the feature/linux-arm64-releases branch 3 times, most recently from 82d8565 to 261279d Compare October 27, 2023 11:21
@nifr nifr marked this pull request as draft October 27, 2023 11:21
@nifr nifr force-pushed the feature/linux-arm64-releases branch 3 times, most recently from 79de16f to 4053986 Compare October 27, 2023 11:50
@nifr nifr force-pushed the feature/linux-arm64-releases branch from 4053986 to 46c43c9 Compare October 27, 2023 11:53
@nifr
Copy link
Contributor Author

nifr commented Oct 27, 2023 •
edited
Loading

PR is ready 🥳

I tested the linux/arm64 build here and fictional v0.1.6 release here.

The aarch64 binary is built successfully and was tested inside a linux/arm64 Debian 12 (bookworm) container on a MacBook Air 2023 (M2).

release (ubuntu-latest, aarch64-unknown-linux-gnu)
succeeded now in 6m 49s

ldd "$(which yazi)"
/usr/local/bin/yazi: ELF 64-bit LSB pie executable, ARM aarch64, version 1 (SYSV), dynamically linked, interpreter /lib/ld-linux-aarch64.so.1, BuildID[sha1]=3ed8ce82c87cb5a82e77648c72df2f89336f9a25, for GNU/Linux 3.7.0, stripped
        linux-vdso.so.1 (0x0000ffff8cf22000)
        libgcc_s.so.1 => /lib/aarch64-linux-gnu/libgcc_s.so.1 (0x0000ffff8c5e0000)
        libm.so.6 => /lib/aarch64-linux-gnu/libm.so.6 (0x0000ffff8c540000)
        libc.so.6 => /lib/aarch64-linux-gnu/libc.so.6 (0x0000ffff8c390000)
        /lib/ld-linux-aarch64.so.1 (0x0000ffff8cee5000)

Screenshots of working binary:

Screenshot 2023-10-27 at 14 10 31 Screenshot 2023-10-27 at 14 10 17

@nifr nifr marked this pull request as ready for review October 27, 2023 12:15
@nifr nifr mentioned this pull request Oct 27, 2023
Closed
1 task
@sxyazi
Copy link
Owner

sxyazi commented Oct 27, 2023

Thank you for the PR, I'm delighted to see linux/arm64 added and passing tests smoothly; I will merge it now!

@sxyazi sxyazi merged commit 396f60d into sxyazi:main Oct 27, 2023
@branchvincent branchvincent mentioned this pull request Jan 15, 2024
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nifr @sxyazi