feat: use USERPROFILE to retrieve readable path on Windows
#331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sxyazi
reviewed
Nov 2, 2023
Owner
|
BTW this was intentionally not implemented for Windows, as it seems that Windows lacks the concept of |
Author
true, windows is weird. On my shell (powershell-core) If i'm not mistaken windows should automatically set the userprofile variable: |
Owner
|
Thank you, LGTM! |
USERPROFILE to retrieve readable path on Windows
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now Yazi only searches for the
$HOMEvariable that is not present on windows. Either the user has to set$env:HOME = "$env:USERPROFILE"in his profile file or Yazi could also check for the$USERPROFILEvariable.My implementation of this functionality is pretty basic