fix: precache n-1 and n+1 pages #349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks for your PR! I've changed it to use a bound as the condition, which should make it more precise. Would you like to give it a review? |
Contributor
Author
|
Thanks for your help. And I found another case that hasn't been fixed. It seems that the n+1 is not cached after the initial load. I push a new commit for this. simplescreenrecorder-2023-11-07_23.41.47.mp4 |
Owner
|
So weird, I can't reproduce it, not sure what's going wrong... |
Owner
|
Ah, I reproduced it when I enlarged my terminal window. I created a new commit that should fix it. |
Contributor
Author
|
Tested it locally, and it works as expected. Thank you! 🎉 |
Owner
|
Okay, let's merge it now. Thanks for your test! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #348
What does this PR do?
yaziand pressG)Test
simplescreenrecorder-2023-11-07_20.30.23.mp4