feat: make Input and Select positions customizable
#361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hanaasagi
commented
Nov 13, 2023
Contributor
Author
Hanaasagi
left a comment
There was a problem hiding this comment.
I think it's close. If you have any questions, please comment directly
sxyazi
reviewed
Nov 13, 2023
sxyazi
reviewed
Nov 13, 2023
Input and Select component customizable
Owner
|
I've simplified the code, would you like to give it a review? |
Hanaasagi
commented
Nov 16, 2023
Hanaasagi
commented
Nov 17, 2023
Contributor
Author
Hanaasagi
left a comment
There was a problem hiding this comment.
I just tested all the positions, and everything is working as expected! 🎉 thank you.
Owner
|
Awesome, I'm merging it now. Thank you so much for contributing this feature! |
Input and Select component customizableInput and Select positions customizable
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs: https://yazi-rs.github.io/docs/configuration/yazi#input
Close: #351