Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: stepwise renaming causes uncertain sorting order #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 25, 2023
Merged

fix: stepwise renaming causes uncertain sorting order #398

merged 4 commits into from
Nov 25, 2023

Conversation

@sxyazi
Copy link
Owner

@sxyazi sxyazi commented Nov 24, 2023

Try to fix #390

@sxyazi sxyazi mentioned this pull request Nov 24, 2023
Closed
Hanaasagi
Hanaasagi approved these changes Nov 24, 2023
View reviewed changes
Copy link
Contributor

@Hanaasagi Hanaasagi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for turning this around so quickly! LGTM

simplescreenrecorder-2023-11-25_00.34.13.mp4

@sxyazi
Copy link
Owner Author

sxyazi commented Nov 25, 2023

Thank you for reporting this issue.

I found several related problems while debugging and fixed them together in this PR.

@sxyazi sxyazi merged commit 47af821 into main Nov 25, 2023
@sxyazi sxyazi deleted the pr-0cdf2d36 branch November 25, 2023 02:10
@branchvincent branchvincent mentioned this pull request Jan 15, 2024
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@Hanaasagi Hanaasagi Hanaasagi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The sorting of the list after renaming is confusing

3 participants

@sxyazi @Hanaasagi