Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: sort naturally #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 26, 2023
Merged

feat: sort naturally #82

merged 3 commits into from
Aug 26, 2023

Conversation

@asim215
Copy link
Contributor

@asim215 asim215 commented Aug 23, 2023

I start to prepare for implementation of natural sorting. But after adding new way of sorting, I expect menu changed and natural sorting appear, but it don't. Where I need to look for that?
For now sorting natural mush act as alphabetical, I will change it later.
Changes in formating created by rust auto format.

@sxyazi
Copy link
Owner

sxyazi commented Aug 23, 2023

Thanks for the PR!

I expect menu changed and natural sorting appear, but it don't

Does it mean the whichkey menu?

@asim215
Copy link
Contributor Author

asim215 commented Aug 24, 2023

Does it mean the whichkey menu?

Yes. I thought it reads keymap.toml and forms whichkey menu from that. Where do I need to look to fix that? I am not really good at Rust right now, but learning. :)
image

@sxyazi
Copy link
Owner

sxyazi commented Aug 24, 2023

I'll look into it later.

@asim215
Copy link
Contributor Author

asim215 commented Aug 24, 2023

Merge sorting keymap here.
I need advice. I don't have enough knowledge in Rust to decide correct way.
I create 2 functions: cmp_natural, cmp_natural_file. And also doubt about how to upwrap file_name correctly to compare.
Which menu is not detecting natural sorting. But I was able to turn it on in config yazi.toml, both natural and natural --reverse.

Natural sort screenshot

image

Natural --reverse sort screenshot

image

@sxyazi
Copy link
Owner

sxyazi commented Aug 24, 2023

Thanks, I'll finish the rest

@sxyazi sxyazi force-pushed the feat/natural_sort branch from 8c652f6 to c712281 Compare August 25, 2023 05:35
@sxyazi sxyazi force-pushed the feat/natural_sort branch from c712281 to c6eb52b Compare August 25, 2023 05:39
@sxyazi sxyazi changed the title feat: prepare for natural sort feat: sort naturally Aug 26, 2023
@sxyazi sxyazi merged commit 388ad43 into sxyazi:main Aug 26, 2023
@asim215 asim215 deleted the feat/natural_sort branch August 28, 2023 07:11
@Porkepix Porkepix mentioned this pull request Sep 2, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@asim215 @sxyazi