[1.8.x] Prepare aarch64 support for sbtn binary #7108
Conversation
|
Hi @mkurz, Thank you for your contribution! We really value the time you've taken to put this together. We see that you have signed the Lightbend Contributors License Agreement before, however, the CLA has changed since you last signed it. |
| ), | ||
| ) ++ (if (isLinux && isArmArchitecture) | ||
| Seq("-H:PageSize=65536") // Make sure binary runs on kernels with page size set to 4k, 16 and 64k | ||
| else Nil), |
There was a problem hiding this comment.
We need to set the page size to 64k for aarch64 binaries to make sure it runs on all kind of kernels.
I did lots of research, collected here: coursier/coursier#2636 (comment)
scala-ci already merged the same fix: VirtusLab/scala-cli#1726
coursier should follow soon: coursier/coursier#2641
|
@eed3si9n If you could take a look, that would be nice. More pull requests are coming afterwards. (Also, I just signed the CLA). Thanks! |
eed3si9n
left a comment
There was a problem hiding this comment.
LGTM
If possible, could you target the default branch (currently 1.9.x branch), and backport next time?
Sure 👍 |
In https://github.com/mkurz/sbtn-dist/commits/aarch64-support I am setting up a GitHub actions job to build a
sbtnbinary for Linux aarch64. To make this happen, the changes in this PR are necessary. I am almost done, binary can be downloaded here already: https://github.com/mkurz/sbtn-dist/actions/runs/3825258120